Skip to content

Comments

[PW_SID:1053862] LRW UART: Patch series for LRW UART driver#1473

Closed
linux-riscv-bot wants to merge 3 commits intoworkflow__riscv__fixesfrom
pw1053862
Closed

[PW_SID:1053862] LRW UART: Patch series for LRW UART driver#1473
linux-riscv-bot wants to merge 3 commits intoworkflow__riscv__fixesfrom
pw1053862

Conversation

@linux-riscv-bot
Copy link

PR for series 1053862 applied to workflow__riscv__fixes

Name: LRW UART: Patch series for LRW UART driver
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1053862
Version: 1

Linux RISC-V bot and others added 3 commits January 29, 2026 08:42
Add documentation for LRW UART devicetree bindings.

Signed-off-by: Wenhong Liu <liu.wenhong35@zte.com.cn>
Signed-off-by: Qingtao Liu <liu.qingtao2@zte.com.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
This commit introduces a serial driver for the LRW UART controller

Key features implemented:
- Support for FIFO mode (16-byte depth)
- Baud rate configuration
- Standard asynchronous communication formats:
  * Data bits: 5, 6, 7, 8, 9 bits
  * Parity: odd, even, fixed, none
  * Stop bits: 1 or 2 bits
- Hardware flow control (RTS/CTS)
- Multiple interrupt reporting mechanisms

Signed-off-by: Wenhong Liu <liu.wenhong35@zte.com.cn>
Signed-off-by: Qingtao Liu <liu.qingtao2@zte.com.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 114.54 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1122.98 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1430.79 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.85 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.53 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 82.44 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
kdoc
Desc: Detects for kdoc errors
Duration: 1.05 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
module-param
Desc: Detect module_param changes
Duration: 0.34 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] LRW UART: dt-bindings: Add binding for LRW UART"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 114.67 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1264.42 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1729.03 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.60 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 5.25 seconds
Result: WARNING
Output:

CHECK: Prefer using the BIT macro
#203: FILE: drivers/tty/serial/lrw_uart.c:98:
+#define UARTFR_TXFF		(1 << 5)	/* used in ASM */

CHECK: Prefer using the BIT macro
#205: FILE: drivers/tty/serial/lrw_uart.c:100:
+#define UARTFR_BUSY		(1 << 3)	/* used in ASM */

CHECK: Alignment should match open parenthesis
#408: FILE: drivers/tty/serial/lrw_uart.c:303:
+static unsigned int lrw_uart_reg_to_offset(const struct lrw_uart_port *sup,
+	unsigned int reg)

CHECK: Alignment should match open parenthesis
#414: FILE: drivers/tty/serial/lrw_uart.c:309:
+static unsigned int lrw_uart_read(const struct lrw_uart_port *sup,
+	unsigned int reg)

CHECK: Alignment should match open parenthesis
#423: FILE: drivers/tty/serial/lrw_uart.c:318:
+static void lrw_uart_write(unsigned int val, const struct lrw_uart_port *sup,
+	unsigned int reg)

CHECK: Alignment should match open parenthesis
#497: FILE: drivers/tty/serial/lrw_uart.c:392:
+static int lrw_uart_dmabuf_init(struct dma_chan *chan, struct lrw_uart_dmabuf *db,
+	enum dma_data_direction dir)

CHECK: Alignment should match open parenthesis
#509: FILE: drivers/tty/serial/lrw_uart.c:404:
+static void lrw_uart_dmabuf_free(struct dma_chan *chan, struct lrw_uart_dmabuf *db,
+	enum dma_data_direction dir)

CHECK: Alignment should match open parenthesis
#1245: FILE: drivers/tty/serial/lrw_uart.c:1140:
+	ret = lrw_uart_dmabuf_init(sup->dmarx.chan, &sup->dmarx.dbuf_a,
+				  DMA_FROM_DEVICE);

CHECK: Alignment should match open parenthesis
#1253: FILE: drivers/tty/serial/lrw_uart.c:1148:
+	ret = lrw_uart_dmabuf_init(sup->dmarx.chan, &sup->dmarx.dbuf_b,
+				  DMA_FROM_DEVICE);

CHECK: Alignment should match open parenthesis
#1258: FILE: drivers/tty/serial/lrw_uart.c:1153:
+		lrw_uart_dmabuf_free(sup->dmarx.chan, &sup->dmarx.dbuf_a,
+				    DMA_FROM_DEVICE);

CHECK: Alignment should match open parenthesis
#1560: FILE: drivers/tty/serial/lrw_uart.c:1455:
+static bool lrw_uart_tx_char(struct lrw_uart_port *sup, unsigned char c,
+			    bool from_irq)

CHECK: Alignment should match open parenthesis
#1673: FILE: drivers/tty/serial/lrw_uart.c:1568:
+			lrw_uart_write(status & ~(UARTICR_TXIC | UARTICR_RTIC | UARTICR_RXIC),
+				      sup, REG_ICR);

CHECK: Alignment should match open parenthesis
#1808: FILE: drivers/tty/serial/lrw_uart.c:1703:
+	lrw_uart_write(lrw_uart_read(sup, REG_IMSC) & ~UARTIMSC_TXIM, sup,
+		    REG_IMSC);

CHECK: Alignment should match open parenthesis
#2001: FILE: drivers/tty/serial/lrw_uart.c:1896:
+static void lrw_uart_shutdown_channel(struct lrw_uart_port *sup,
+	unsigned int mcfg, unsigned int fcr)

CHECK: Please don't use multiple blank lines
#2188: FILE: drivers/tty/serial/lrw_uart.c:2083:
+
+

CHECK: Alignment should match open parenthesis
#2287: FILE: drivers/tty/serial/lrw_uart.c:2182:
+static int lrw_uart_rs485_config(struct uart_port *port, struct ktermios *termios,
+			      struct serial_rs485 *rs485)

CHECK: Alignment should match open parenthesis
#2613: FILE: drivers/tty/serial/lrw_uart.c:2508:
+static int __init lrw_uart_early_console_setup(struct earlycon_device *device,
+					      const char *opt)

CHECK: Alignment should match open parenthesis
#2699: FILE: drivers/tty/serial/lrw_uart.c:2594:
+static int lrw_uart_setup_port(struct device *dev, struct lrw_uart_port *sup,
+			      struct resource *mmiobase, int index)

CHECK: Alignment should match open parenthesis
#2898: FILE: drivers/tty/serial/lrw_uart.c:2793:
+		pr_err("Could not register %s driver\n",
+			lrw_uart_driver.driver_name);

total: 0 errors, 0 warnings, 19 checks, 2886 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 85492ef07e5b ("LRW UART: serial: add driver for the LRW UART") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 19 checks, 2886 lines checked
CHECK: Alignment should match open parenthesis
CHECK: Please don't use multiple blank lines
CHECK: Prefer using the BIT macro


@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 82.53 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
kdoc
Desc: Detects for kdoc errors
Duration: 2.19 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
module-param
Desc: Detect module_param changes
Duration: 0.33 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] LRW UART: serial: add driver for the LRW UART"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1053862 branch February 21, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants